Re: cvs: php4(PHP_4_3) /ext/zlib zlib.c

Sander Roobol <sander@php.net> wrote: > On Thu, May 22, 2003 at 04:37:30AM +0900, Moriyoshi Koizumi wrote: > > Okay, it seems I was missing that point. Feel free to apply again the > > gzip_output_handler portion of your patch. Although, it's > > still not a good idea to bring it in to ob_gzhandler() as well since > > the handler is not necessarily in the bottom of ob stack. > > But ob_gzhandler already sends two headers (Content-Encoding and Vary), > so another one shouldn't hurt. Or am I missing something? Yep, those headers shouldn't be sent in the first place. I think there's no need to repeat such a mistake any further as it really need refactoring instead of something workaroundish. Moriyoshi