Re: cvs: /php3 ChangeLog

At 22:24 24/11/1999 , Sascha Schumann wrote:

I like the approach of simply removing the username/password from the hashed-details and always doing a change_user() on a pconnect. That shouldn't be hard to do and I will take a whack at it today.

    Urgh, another layer for a special version and more
    precompiler directives... one day, someone should clean up
    mysql.c.

    To see what I mean have a look at php3_mysql_do_connect(). It
    should be at least split up into multiple functions.

Well, I'm not sure where's your frustration comes from. Actually I do, but it's such a typical case of backwards compatibility that I didn't expect you to get upset by it. It's as simple as that - we can decide to drop support for earlier versions of MySQL, or we can choose to have code that has compiler directives in it. You say it calls for dividing it to subfunctions? Perhaps, even though I personally don't think I agree. As for this specific case, I wouldn't add a single compiler directive here. I'll take the approach that we should aim for best performance (that is, speed&feature wise) for people who use the latest versions of the software in question. In this case it means removing the username/password pair from the hash key completely and creating a mechanism for username/password verification that's separate from the hash key, all that, *regardless* of the MySQL version. The only compiler directive help we need is around mysql_change_user(), which we must have anyway. So, people who use the latest version of MySQL would enjoy change_user(), and people who don't will suffer a slight performance decrease (which is ok, since as time passes by, their number will become less and less significant). Zeev -- Zeev Suraski <zeev@zend.com> http://www.zend.com/