Re: cvs: /php3 ChangeLog

At 01:05 25/11/1999 , Sascha Schumann wrote:

On Wed, Nov 24, 1999 at 11:43:28PM +0200, Zeev Suraski wrote: I completely disagree with you. You think I remember each and every part of Zend? I sure as hell don't and don't ever plan to. It doesn't mean it cries for a rewrite, it means it's large-scale and perhaps somewhat complex (and because it does complex things, not because it's badly implemented).

    "Complex tasks require complex code"

    That is basically true, if you are not interested in code
    maintainability.

Sometimes it's true regardless of what you're interested in. There are plenty of things that are complex by nature, and cannot be sorted out by simple code, even if you'd really really want to have your code as maintainable as possible. I'll argue that do_connect() is hardly complex code, considering understanding it meant reading it while scrolling down at about 5 lines/sec. I understand your motivation about maintainability, and it's a bit amusing since you very much remind me of myself about 1.5 years ago fighting plenty of old habits from PHP/FI 2, only now I'm not pedantic enough to you likings :) Nonetheless, I don't think you have a case in this particular issue. do_connect() can be simplified a tiny bit by avoiding lots of compiler directives, and perhaps have its key generation and other persistent stuff generalized and put as API functions to Zend as suggested a few months ago, but logic wise, it's exactly as it should be, and it's not complex. Zeev -- Zeev Suraski <zeev@zend.com> http://www.zend.com/