Re: Re: array_change_key_case()? key_exists()?
| From: | James Moore | Date: | Mon, 12 Nov 2001 00:09:11 +0000 |
| Subject: | Re: Re: array_change_key_case()? key_exists()? | ||
| References: | 1 | Groups: | php.dev php.doc |
| Request: | Send a blank email to php-dev+get-70177@lists.php.net to get a copy of this message | ||
>
> > Jeroen what you did was completely irresponsible. Without even starting
a
> > discussion about whether a function is needed or not you take steps to
> > undocument them?!?
>
> Although I did 'undocument' them, I did so only __temporarily__
> (otherwise I'd have removed it really, not placed it inside a comment).
> The one and only reason to do so, is to prevent a BC problem in the case
> it turns out that this function will be changed/removed. Wether or not
> this will happen, is something I wanted to discuss -- the problem is
> simply that it'd be a lot harder to change function if it's documented,
> so I merely intended to postponed the documentation.
>
> As soon as - after discussion - it is decided that this function will
> stay, the comment marks should be removed. I'm only asking: let's
> discuss the function itself first.
Jereon you should have sent an email to Hojtsy saying look lets discuss if
these need to be renamed before we document them, could you revert you patch
for a few mins, or just send a mail to php-dev bringing the point to our
attention there was very little need to go and mess with what Hojtsy had
just spent hours working on (TBH somthing being in XML form for a day or two
isnt that terrible. it might appear on the site briefly there are far worse
things that can happen), you then, after derick changes the funtion name to
array_* and commits the change to php4 and phpdoc and then uncomments
Hojtsy's work and recommits it, you imediatly revert dericks patch.
Personally I think that is rude, unneeded and not done in a cooperative way,
generally in opensource its a good idea to try and be as plesant as possible
and to try and get on with developers, you have on serveral ocasions shown
blatiant disregard for other developers (commiting the rand thing without
proper discussion, this documentation thing). I can understand why derick
wants your cvs access revoked and I agree with him that you should not have
cvs access until you can learn not to tread on toes and be less "rubbing".
Anyway my £2.00
- James