Re: [Patch] LDAP Error reporting for 4.2.1

On Tue, 25 Jun 2002, Kristofer T. Karas wrote: > I'm using OpenLDAP 1.x in PHP 4.2.1, and was dismayed that > $x = @ldap_add(...); > dumps verbiage to stderr if the add fails, despite the "@". > > Figured it'd be faster to fix it than to whine and complain. > > In fixing, I found some inconsistency in the way errors are reported - > some with explanations (e.g. a call to ldap_err2string) and some > without. I removed the offending ldap_perror calls (which don't honor > "@", obviously) and augmented the php_error calls. Patch attached. > > Oh, I couldn't find a FAQ question handy regarding patch submission, so > I hope I'm not violating etiquette. At least the patch isn't enormous. > :-) I'm not the right person to verify your patch (although it looks good :-) but there is a README about patch submissions: http://cvsweb.php.net/co.php/php4/README.SUBMITTING_PATCH Regards, -\- David Eriksson -/- "I personally refuse to use inferior tools because of ideology." - Linus Torvalds