Re: [Patch] LDAP Error reporting for 4.2.1

On Wed, 26 Jun 2002, Stig Venaas wrote: > On Tue, Jun 25, 2002 at 08:13:29PM -0400, Kristofer T. Karas wrote: > > I'm using OpenLDAP 1.x in PHP 4.2.1, and was dismayed that > > $x = @ldap_add(...); > > dumps verbiage to stderr if the add fails, despite the "@". > > > > Figured it'd be faster to fix it than to whine and complain. > > > > In fixing, I found some inconsistency in the way errors are reported - > > some with explanations (e.g. a call to ldap_err2string) and some > > without. I removed the offending ldap_perror calls (which don't honor > > "@", obviously) and augmented the php_error calls. Patch attached. > > > > Oh, I couldn't find a FAQ question handy regarding patch submission, so > > I hope I'm not violating etiquette. At least the patch isn't enormous. > > :-) > > Thanks, I'll review your patch more carefully before I apply it, but > it looks good. We should indeed be consistent. Mailing patches to > this list is fine. Stig, I just patched it... and made it even more conformant to the rest of the PHP extensions. I am currently testing. Derick --------------------------------------------------------------------------- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --------------------------------------------------------------------------- PHP: Scripting the Web - derick@php.net All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net ---------------------------------------------------------------------------