[Patch] LDAP Error reporting for 4.2.1
| From: | Kristofer T. Karas | Date: | Wed, 26 Jun 2002 00:13:29 +0000 |
| Subject: | [Patch] LDAP Error reporting for 4.2.1 | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-85584@lists.php.net to get a copy of this message | ||
I'm using OpenLDAP 1.x in PHP 4.2.1, and was dismayed that
$x = @ldap_add(...);
dumps verbiage to stderr if the add fails, despite the "@".
Figured it'd be faster to fix it than to whine and complain.
In fixing, I found some inconsistency in the way errors are reported -
some with explanations (e.g. a call to ldap_err2string) and some
without. I removed the offending ldap_perror calls (which don't honor
"@", obviously) and augmented the php_error calls. Patch attached.
Oh, I couldn't find a FAQ question handy regarding patch submission, so
I hope I'm not violating etiquette. At least the patch isn't enormous.
:-)
Kris