Re: [Patch] LDAP Error reporting for 4.2.1
| From: | Kris Karas | Date: | Sat, 29 Jun 2002 07:58:15 +0000 |
| Subject: | Re: [Patch] LDAP Error reporting for 4.2.1 | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-85666@lists.php.net to get a copy of this message | ||
On Thu, 2002-06-27 at 02:26, derick@php.net wrote:
> Here is the patch:
>
> http://cvs.php.net/diff.php/php4/ext/ldap/ldap.c?r1=1.121&r2=1.123&ty=u
>
> (And I just fixed that \n thing :)
Super. Tested over the past 36 hours or so, no problems encountered.
If you want to, feel free to change those entries that read
"%s(): The ldap_foo call failed: %s"
to
"%s(): %s"
as the automatic funtion-name inclusion makes most of the error text
pretty redundant. I had added the text in my patch so as to give the
user a clue as to which of his/her functions triggered the error; but
that was without realizing that PHP4 provides a more automatic and
elegant mechanism for doing this automatically.
Then again, since routines such as ldap_sort are unlikely to fail unless
one's LDAP libraries are seriously hosed, I guess the error text is
rather academic. :-) But the higher priority goal of the patch - to
make @ldap_xxx honor the "@" and not print error text - has succeeded.
Kris