Re: PATCH: debug_backtrace() function for 4.3-dev/ZE1
| From: | Andi Gutmans | Date: | Tue, 20 Aug 2002 04:25:55 +0000 |
| Subject: | Re: PATCH: debug_backtrace() function for 4.3-dev/ZE1 | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-87123@lists.php.net to get a copy of this message | ||
At 12:30 PM 8/19/2002 +0200, you wrote:
On Mon, Aug 19, 2002 at 11:45:30AM +0300, Zeev Suraski wrote: How often do you call a function that gives you your current backtrace in C? In my many years of C experience, I would have to say that the accurate answer is -0- times. You really should compare apples with apples...I still think it shouldn't go in. This is the only feature in Engine 2 which might make non-OOP people convert. Once this isn't in Engine 2 we don't have a carrot for them. Why can't you respect this way of thinking? Especially as I wrote the code? You're basically saying screw them because I'll commit it anyway. Andiyou often said in the past that you don't write php-apps, you write php. i do write php-apps, and debug_backtrace() is one of the most useful features if your app reaches an "unexpected failure" (= likely a bug). right now i load some zend-extension on my devel boxes - but (as you know), the unexpected often only happens on productions systems. my production systems are soo loaded that i cannot afford to load the zend-extension on there. so post-mortem analysis is much harder there, and you know how hard it sometimes is to reporduce bugs (remember how often i spend hours just to sent you guys the shortest-possible testcase for bugs?)but - in a way you are right, i'm comparing apples and pies. the debug_backtrace() for me is like calling abort() in my c-code to be able to inspect the core-file and see where things went wrong.anyway, i don't thing we are discussing the usefullness of debug_backtrace() here.i think andi will look over the one critical line of the patch - if he agrees that this change is "ok", i will go ahead and commit.