Re: Re: mbstring

On Tue, 3 Sep 2002 07:13:41 +0100 "James Cox" <imajes@php.net> wrote: > > > > I think that the problem is caused by > > --enable-mbstr-enc-trans option and is not caused by mbstring itself. > > > > If --enable-mbstr-enc-trans is enabled, > > php_treat_data, the original handler of user input (POST/GET/Cookie), > > is overrided by mbstr_treat_data in ext/mbstring , > > the multibyte enabled version. > > > > mbstr_treat_data had a GET handling bug in PHP 4.2.x/PHP 4.1.x. > > Although the bug was already fixed in CVS, > > but mbstr_treat_data is not used by non multibyte user. > > > > So, I abolished --enable-mbstr-enc-trans option in CVS, > > and made a new php.ini option 'mbstring.encoding_translation', > > which is the equivalent of --enable-mbstr-enc-trans, > > and which is 'Off' by default. > > so this is now always on, but controlled by an ini variable? that doesn't > sound very good. maybe i'm being paranoid, but it seems to me that you've > just enabled it by default (at build time). No, this option is 'disabled' by default, and can be enabled by a ini variable. mbstring.encoding_translation = Off; is default. If mbstring.encoding_translation = On is set in php.ini, the transparent conversion will be enabled. > > > > I think the user input (POST/GET/Cookie) related problem > > for non-multibyte user will completely disappeer with this change. > > > > And, > > the mbstring should be 'enabled' by default. > > I18N of PHP is very important for especially multibyte PHP users. > > [snip] > > I agree with Zeev, the simplicity of development work is important. > > So, the duplicate code of the user input handler should be merged > > with the original handler in PHP 5.0. > > > > I agree -- it's very useful.. but i don't think it should exist as an > extension, but built in.. the extension just now seems a really messy way of > doing it. Yes, I think mbstring is very fundamental feature and it should be built-in feature (in PHP 5.0). But, string related functions and some other core functions are included in ext/standard which is also in extension part. Rui -- ----------------------------------------------------- Rui Hirokawa <rui_hirokawa@ybb.ne.jp> <hirokawa@php.net>