Re: highlight_file modification

Output from show_source using the current patch can be found at http://www.dapond.net/code/bleh.html This still doesn't implement the .phps?linenumbers (since that's gonna have to do with the server module/cgi binary code) and also since nobody's (yet) given input as to what variable name would be sufficient. show_line_numbers? Headers/footers will also have to go in the server module/cgi code to implement XHTML/1.1 for the output, since I can't think of a way to figure out whether zend_highlight() was called from the apache_php_module_main function (or, simply to tell whether or not it was called from anywhere other than highlight_file/highlight_string). Dunno. I'm still messing around with a couple things, I want to have no floating tags (you can see that they exist by some of the </font> tags with no <font> initializer)... wanna get everything "perfect" before I release the patch. So far, I think it's looking pretty good if you ask me :). Devon Original Message: ----------------- From: Dan Hardiker dhardiker@staff.firstcreative.net Date: Wed, 11 Sep 2002 21:36:40 +0100 (BST) To: Sascha@GaNoAn.org, webmaster@tsn.dk, php-dev@lists.php.net Subject: Re: [PHP-DEV] highlight_file modification >> If you can think of an alternative way to enable / disable the >> modifications suggested other than using a php.ini entry... ;) > [...] > > wouldn't it be better to let the viewer decide, if line numbers should > appear or not. This wouldn't break BC and also would not be needed to > be enabled on any server. Maybe we could use a GET Param on this (only > for the .phps's) like: > > http://localhost/test.phps?linenumbers=0 > http://localhost/test.phps?linenumbers=1 > > in which we would default linenumbers to zero. +1 ... sounds like everyone wins. We hit maximum deployment with minimum impact on systems that want to remain the way they are now. -- Dan Hardiker [dhardiker@staff.firstcreative.net] ADAM Software & Systems Engineer First Creative Ltd -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php -------------------------------------------------------------------- mail2web - Check your email from the web at http://mail2web.com/ .