Re: highlight_file modification

I'm not sure how you have changed buffer. Anyway, modules are better to be independent from each other. Make Zend and PHP depend each other is not a good idea. Therefore, I would like to leave phps alone for now until Zend became fully I18N. Make sense? -- Yasuo Ohgaki Devon O'Dell wrote:

I've implemented a lot better code output in this. Would you like to help me implement mbfilter into this (if it's supported in the spoken php build) where necessary. The buffer code is already tweaked, I added 2 output functions specifically for the highlighting (just slightly modified versions of zend_html_puts and zend_html_putc, called zend_highlight_puts and zend_highlight_putc) because it just works better and it doesn't break anything outside the highlighting functions that relies on the html_put* functions. Currently, the page isn't even HTML compliant. That's changed in my patched version, I expect to complete that today. Anyway, later Devon Yasuo Ohgaki wrote:

Devon O'Dell wrote:

What buffer and encoding stuff are you talking about?! show_source() is an FALIAS to highlight_file() which calls zend_highlight(). phps files via apache call zend_highlight(). Where are you going with this?

Read source how things are sent to browser and play with some encodings :) Current code is not smart enough to handle all cases correctly. To handle output appropriately, we need to implement mbfilter in Zend and tweak buffer code a little as well as related Zend code. -- Yasuo Ohgaki

Devon Yasuo Ohgaki wrote:

phps may not work under Apache 1.3.x also. Any addition to phps does not worth the effort. People should use show_source() etc instead of phps.

It works under some condition, but it's not on some configuration/usage. Buffer and encoding is the cause of malfunction. Therefore, I recommend use of show_source() instead of phps. -- Yasuo Ohgaki