Re: highlight_file modification
| From: | Yasuo Ohgaki | Date: | Thu, 12 Sep 2002 00:17:02 +0000 |
| Subject: | Re: highlight_file modification | ||
| References: | 1 2 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-88221@lists.php.net to get a copy of this message | ||
Edin Kadribasic wrote:
On Wed, 11 Sep 2002 13:47:56 +0200 "Devon O'Dell" <devon@sitetronics.com> wrote:+1 for no more ini directives... No more ini entry unless it is strictly required/prefered. -- Yasuo OhgakiHey, I don't know if this has been brought up before (you can smack me, I know that's the 3rd time I've said this), but something I (and others) thought would be cool is line numbering for highlight_file (aka show_source). I've made modifications so that this feature is settable from php.ini (highlight.format, either 0 or 1) and tested my source, looks like it works fine and the only stuff that didn't work in make test was stuff where the EXPECT was wrong.Please let's not add an ini setting for every little thing. It makes writing portable scripts very difficult. I think that it would be preferrable to add an optional parameter to the exisiting function, or make a new function.