Re: highlight_file modification
| From: | Devon O'Dell | Date: | Fri, 13 Sep 2002 08:49:23 +0000 |
| Subject: | Re: highlight_file modification | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-88303@lists.php.net to get a copy of this message | ||
Hm, actually...
I have gotten everything working *except* there is one weird little thing that happens with indenting for some token types because of the way that I have my output ordered. The reason for this is because I cannot (don't want to) call zend_html_puts() with an additional argument... which would break some other functions that call zend_html_puts() (namely in info.c).
Actually, the problem is in zend_html_putc() - in the previous version, it could just find \n and replace it with a <br />, but it's a bit different with tables.
It is a huge problem if I just write my own version of these two functions to separate the highlighting functions from the generic zend_html_put*() functions (because there's a ton more of the same code than there would be if I just added an additional argument to the functions)
I'm thinking the *BEST* thing i can do is just add an extra variable to the zend_html_puts() and zend_html_putc() and fix the info.c and main.c and basic_functions.c (I think thats the only place where other calls occur) to call the function with a define to specify normal output. This would be faster/easier/better. I just wanted to make sure this would be a good idea before changing stuff in these files.
:\
Other ideas?
Devon