Re: [PATCH] Redirect on Error
| From: | Zeev Suraski | Date: | Tue, 26 Nov 2002 11:01:29 +0000 |
| Subject: | Re: [PATCH] Redirect on Error | ||
| References: | 1 2 3 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-91705@lists.php.net to get a copy of this message | ||
They should definitely be in the C code. Look at gettext as a pretty good example.
Taking them out is seriously inferior to having them in - it makes maintenance much tougher, and PHP itself less robust. Suddenly, if you don't have some external file, errors would show up as stupid error numbers. What are we looking forward to? Having something like "Error 29871" and then having to look up error 29871 and seeing it means "Unable to find external error message database"?
No, please.
About the topic of internationalized error messages in general - I think the cons outweigh the pros. If we were, however, to ever internationalize them - it would have to be optional, and with the full hardcoded error messages inside the code remaining intact.
Zeev
At 13:01 26/11/2002, Maxim Maletsky wrote:
I apologize for shouting, didn't mean to be offensive. What I want to say is that error messages are string and should, IMHO, be reference instead of hardcoded in the C code. -- Maxim Maletsky maxim@php.net