Re: [PATCH] new idate() - sunrise() - sunset() functions

I don't think this is good idea. date_sunset(), date_sunrise() are better. Andrey ----- Original Message ----- From: "moshe doron" <mosdoron@netvision.net.il> To: <php-dev@lists.php.net> Sent: Friday, February 07, 2003 2:37 PM Subject: Re: [PHP-DEV] [PATCH] new idate() - sunrise() - sunset() functions > well, what about sun_set(), sun_rise()? > > moshe > -- > > > "Andi Gutmans" <andi@zend.com> wrote in message news:5.1.0.14.2.20030207141050.054b15f0@127.0.0.1... > > At 12:47 PM 2/7/2003 +0200, moshe doron wrote: > > >"Andi Gutmans" <andi@zend.com> wrote in message > > >news:5.1.0.14.2.20030207102137.03bc7798@127.0.0.1... > > > > I haven't been following this whole discussion. > > > > However, the function names should follow the coding standards and be > > > named > > > > something like date_sunrise(), date_sunset() (or whatever other prefix > > > > makes sense). > > > > > > > > > >here is part of my replay to Leon Atkinson: > > > > Also, shouldn't sunrise() and sunset() be cal_sunrise() and cal_sunset()? > > > > > > >well, since sunset() & sunrise() have aspects more then cal_* related, i > > >thought the right place is standard. > > > > > >new astronomy extension, or linking against exisint lib, 'll be overhead > > >since i want use it on the calendar extension, that is build by default on VC. > > > > Even functions in standard have a prefix. Only ancient ones don't and we > > didn't fix them for BC reasons. > > > > Andi > > >