Re: First patch review - scoutapm PECL extension docs

On 30.12.2019 at 11:26, James Titcumb wrote: > Please could someone check my patch looks OK before I commit to it? I'm > adding docs for the new scoutapm PECL extension. > > I've validated it with the local build tools already, and checked the > documentation generated looks ok, but I'd appreciate someone just checking > I've not made any breaking mistakes :) > > I've generated an svn diff and put it in a gist, please do let me know if > there's anything else needed: > https://gist.github.com/asgrim/d3f7e5c0cd5d396d323e06c065d8890e On a quick look, this looks good to me, except that book.developer.xml appears to be superfluous, and that there should be some info that the extension can't be used on Windows. Also, please ensure that you have the proper SVN settings set; see <http://doc.php.net/tutorial/faq.php>, last section. -- Christoph M. Becker