Re: First patch review - scoutapm PECL extension docs
| From: | Christoph M. Becker | Date: | Mon, 30 Dec 2019 18:39:53 +0000 |
| Subject: | Re: First patch review - scoutapm PECL extension docs | ||
| References: | 1 2 3 4 5 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387438@lists.php.net to get a copy of this message | ||
On 30.12.2019 at 16:34, James Titcumb wrote:
> OK - done that. I'll check the docs tomorrow to make sure everything looks
> good.
Great! I've just noticed that the "Resource Types" section is empty.
You could either insert &no.resource; there, or, in my opinion, just
drop that section. Also I suggest to shorten the <refpurpose> of
scoutapm_get_calls(), and to move its current contents to the
description section; as it is now, it doesn't look neat:
<http://docs.php.net/manual/en/book.scoutapm.php>.
> Thank you very much for your help!
Thank you for providing extension documentation!
--
Christoph M. Becker