Re: First patch review - scoutapm PECL extension docs

On Mon, 30 Dec 2019 at 13:07, Christoph M. Becker <cmbecker69@gmx.de> wrote: > On a quick look, this looks good to me, except that book.developer.xml > appears to be superfluous, and that there should be some info that the > extension can't be used on Windows. > Thank you very much for checking. I wasn't sure what book.developer.xml actually was, it was generated by the tool originally. I've removed that, and added notes about not being available on Windows. Also, please ensure that you have the proper SVN settings set; see > <http://doc.php.net/tutorial/faq.php>, last section. > Check! I think this looks right: $ cat ~/.subversion/config | grep xml *.xml = svn:eol-style=native;svn:keywords=Id Rev Revision Date LastChangedDate LastChangedRevision Author LastChangedBy HeadURL URL One other quick question I had - which repo should I commit first (docs-base or en)? Does the order matter? If anyone else is able to check, the updated diff is at https://gist.github.com/asgrim/81d0c60add19717a7ec799b680140352 Thanks James