Re: First patch review - scoutapm PECL extension docs
| From: | James Titcumb | Date: | Mon, 30 Dec 2019 19:06:22 +0000 |
| Subject: | Re: First patch review - scoutapm PECL extension docs | ||
| References: | 1 2 3 4 5 6 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387439@lists.php.net to get a copy of this message | ||
Hi Christoph,
On Mon, 30 Dec 2019, 18:39 Christoph M. Becker, <cmbecker69@gmx.de> wrote:
>
> Great! I've just noticed that the "Resource Types" section is empty.
> You could either insert &no.resource; there, or, in my opinion, just
> drop that section.
Yep, good call.
I suggest to shorten the <refpurpose> of
> scoutapm_get_calls(), and to move its current contents to the
> description section; as it is now, it doesn't look neat:
> <http://docs.php.net/manual/en/book.scoutapm.php>.
>
Yes that makes sense, I'll send a patch for these tweaks tomorrow.
Thanks so much for the feedback, it's very helpful!
Thanks
James