Re: Re: [VOTE] Random Extension Improvement
| From: | Guilliam Xavier | Date: | Tue, 12 Jul 2022 13:42:13 +0000 |
| Subject: | Re: Re: [VOTE] Random Extension Improvement | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-118254@lists.php.net to get a copy of this message | ||
> > https://wiki.php.net/rfc/random_extension_improvement
>
> Hi Internals.
>
> Currently, the renaming of Randomizer::shuffleString() to
> Randomizer::shuffleBytes() seems acceptable.
>
> I forgot to note the change regarding arguments when I submitted this RFC.
> With this change, the argument was supposed to be changed from `string
> $string
to string $bytes`.
>
> -
> https://github.com/php/php-src/pull/8094#discussion_r916630626
For reference, first was
https://github.com/php/php-src/pull/8094/commits/32e83a71eae67fdd822fd12ded5a8c054024a4da#r916058794
> Is this change acceptable? Or should I keep string $string?