Re: [VOTE] Random Extension Improvement

From: Date: Tue, 19 Jul 2022 20:22:04 +0000
Subject: Re: [VOTE] Random Extension Improvement
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-118288@lists.php.net to get a copy of this message
Hi On 7/16/22 08:11, Go Kudo wrote:
However, as pointed out in the PR, there are still areas that need to be improved and corrected. First of all, overloading of getInt() should be stopped. This is due to the fact that the signature of the mt_rand() function is still used, but it was pointed out that no new implementation should be made. https://github.com/php/php-src/pull/8094/files#r919693108 Second, there is an issue regarding the handling of header files for compatibility. This was left in because it was considered necessary in previous discussions, but it has been suggested that it is unnecessary. I too would like to remove it if possible. https://github.com/php/php-src/pull/8094/files#r917308676 However, if you try to make this change by creating an RFC as usual, you are already out of time. I am really confused and don't really know what to do about this. Can anyone give me some good ideas?
For those following along, the follow-up PR is here: https://github.com/php/php-src/pull/9052 Best regards Tim Düsterhus

« previous php.internals (#118288) next »