Re: [RFC] [Discussion] Add WHATWG compliant URL parsing API
| From: | Máté Kocsis | Date: | Mon, 10 Mar 2025 22:58:16 +0000 |
| Subject: | Re: [RFC] [Discussion] Add WHATWG compliant URL parsing API | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126704@lists.php.net to get a copy of this message | ||
Hi Juris and Tim,
> Am 2025-02-23 18:47, schrieb Juris Evertovskis:
> > As those are URI validation errors, maybe something like
> >
Uri\WhatWg\ValidationError would be both less clashy and
> > less
> > redundant?
>
> I like that suggestion.
>
> Best regards
> Tim Düsterhus
>
I liked it as well, so I changed the related classes the following way:
- Uri\WhatWg\WhatWgError became Uri\WhatWg\UrlValidationError
- Uri\WhatWg\WhatWgErrorType became Uri\WhatWg\UrlValidationErrorType
This way, WhatWg is not duplicated in the FQCN, but the class name is still
specific enough to possibly not clash with anything else.
I could also imagine removing the Url prefix, but I like it, since it
highlights that it's related to WHATWG URLs.
Regards,
Máté