Re: [RFC] [Discussion] Add WHATWG compliant URL parsing API
| From: | Máté Kocsis | Date: | Tue, 18 Mar 2025 20:15:52 +0000 |
| Subject: | Re: [RFC] [Discussion] Add WHATWG compliant URL parsing API | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-126829@lists.php.net to get a copy of this message | ||
Hi Paul,
> If we want a full-featured WHATWG-URL implementation in core, would it not
> be preferable (with Trevor's permission) to convert rowbot/url from
> userland to core instead? Surely conversion from an existing, well-tested,
> widely-used implementation would be easier/better/faster than writing an
> implementation from scratch.
>
There's no way I would have written an implementation from scratch. I'm
using the url module of the Lexbor C library (
https://github.com/lexbor/lexbor/) for handling
WHATWG URLs. It's already
bundled in core, and it's also battle tested, and it has exceptional
maintenance. All I had to implement is the glue between userland and the C
library.
Máté