Re: [RFC] [Discussion] Add WHATWG compliant URL parsing API

Hi Ignace, The $excludeFragment is true by default so in the example it should be > false instead. Perhaps using an Enum instead would make the > DX easier than using a boolean ? > I believe the same issue is in all examples regarding the use of that > parameter. > You are right, I completely messed up the value of the $excludeFragment variables in the examples. After having thought about your suggestion, I'm fine with adding the enum. It's a bit verbose indeed, but at least it properly conveys the meaning of the parameter, so hopefully it will reduce the number of WTFs when people start to use the new API. :) I fiddled a little bit with the implementation, and I went with the Uri\UriComparisonMode enum name at last. I hope that it is OK on your side. Regards, Máté