Re: [RFC] [Discussion] Add WHATWG compliant URL parsing API
| From: | Tim Düsterhus | Date: | Tue, 29 Apr 2025 18:55:04 +0000 |
| Subject: | Re: [RFC] [Discussion] Add WHATWG compliant URL parsing API | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-127243@lists.php.net to get a copy of this message | ||
Hi
On 4/29/25 10:54, ignace nyamagana butera wrote:
I have one last question while reviewing my polyfill implementation. Is it worth it adding a SensitiveParameter attribute on the argument of the following methods ? - Uri\Rfc3986\Uri::withUserInfo - Uri\WhatWg\Url::withPassword I'm fine with any answer ? Does it warrant a paragraph in the RFC ? That I do not know but I feel the question may be raised ?Good catch. Since they may throw an exception for malformed inputs, they should have the attribute. Especially since folks might try to use special characters in passwords, which might need encoding. No paragraph in the RFC needed, but the attribute should be added to the “stub”. Best regards Tim Düsterhus