Re: TSRM changes broke windows compile
| From: | Stanislav Malyshev | Date: | Fri, 25 May 2007 17:28:44 +0000 |
| Subject: | Re: TSRM changes broke windows compile | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-29762@lists.php.net to get a copy of this message | ||
I tried removing recently added include to SAPI.h and it compiles just fine now. In general, I think linking TSRM to SAPI is not a good idea. It means, among other things, that TSRM can never be used in a context that not links it to PHP. This is something that wasn't before and I don't think that introducing such change in a minore bugfix version worth it, yet more - for a miniscule performance optimization.
Stanislav Malyshev wrote:
Recent TSRM changes seem to break the windows compilation for me. I'm getting: tsrm_virtual_cwd.c C:\Program Files\Microsoft Visual Studio 8\VC\PlatformSDK\include\winsock2.h(112 ) : error C2011: 'fd_set' : 'struct' type redefinition-- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/C:\Program Files\Microsoft Visual Studio 8\VC\PlatformSDK\include\winsock.h(54) : see declaration of 'fd_set' C:\Program Files\Microsoft Visual Studio 8\VC\PlatformSDK\include\winsock2.h(147 ) : warning C4005: 'FD_SET' : macro redefinition and so on many times. PHP compiled just fine for a long time with the same setup for me, broke just very recently. Any ideas what happened?