Re: TSRM changes broke windows compile

From: Date: Sat, 26 May 2007 01:03:16 +0000
Subject: Re: TSRM changes broke windows compile
References: 1 2 3 4 5 6 7 8  Groups: php.internals 
Request: Send a blank email to internals+get-29788@lists.php.net to get a copy of this message
Well, by that logic you would be fine with: #define TIME_CALL sapi_get_request_time(TSRMLS_C) and in tsrm_virtual_cwd.c #ifndef TIME_CALL define TIME_CALL time(0) #endif ... t = CWDG(realpath_cache_ttl)?TIME_CALL:0;
Theoretically yes, that could work, but:
that makes it environment-dependent instead of explicitly-dependent, and also way harder to debug. Environmental side-effects like that are nasty.
Exactly. So I'd propose to think how to do it right - not excluding taking the whole cache & system-dependant filesystem things out of TSRM. They do not really related to the rest of TSRM and could be abstracted same way as open/output/error functions are abstracted. -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/

« previous php.internals (#29788) next »