An extra syscall on every file open isn't exactly miniscule.
It's a syscall not related to any filesystem or I/O so it can't be that bad. And we managed to live with it so far.
Edin also just built Windows binaries without problems. Why did it work
for him?
I have no idea. But it is obvious that it doesn't work in all environments, and it worked before just fine. Anyway, both breaking build _and_ intoducing dependency of TSRM on PHP and both in a minor version _and_ both without discussing it doesn't look like very good idea to me. I would propose:
1. Revert it for 5.2.3
2. Discuss if we want TSRM/Zend be now usable only with PHP
3. Discuss if we really need this patch and if so can we do it without breaking (2)
--
Stanislav Malyshev, Zend Products Engineer
stas@zend.com http://www.zend.com/