Re: TSRM changes broke windows compile
| From: | Rasmus Lerdorf | Date: | Fri, 25 May 2007 19:20:48 +0000 |
| Subject: | Re: TSRM changes broke windows compile | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-29769@lists.php.net to get a copy of this message | ||
Stanislav Malyshev wrote:
> I tried removing recently added include to SAPI.h and it compiles just
> fine now. In general, I think linking TSRM to SAPI is not a good idea.
> It means, among other things, that TSRM can never be used in a context
> that not links it to PHP. This is something that wasn't before and I
> don't think that introducing such change in a minore bugfix version
> worth it, yet more - for a miniscule performance optimization.
An extra syscall on every file open isn't exactly miniscule.
Edin also just built Windows binaries without problems. Why did it work
for him?
-Rasmus