RE: [PHP-DEV] Patch for macros for tracking refcount and is_ref
| From: | Andi Gutmans | Date: | Fri, 07 Sep 2007 18:29:34 +0000 |
| Subject: | RE: [PHP-DEV] Patch for macros for tracking refcount and is_ref | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-32096@lists.php.net to get a copy of this message | ||
> -----Original Message-----
> From: Derick Rethans [mailto:derick@php.net]
> Sent: Friday, September 07, 2007 12:09 AM
> To: Andi Gutmans
> Cc: David Wang; Marcus Boerger; Nuno Lopes; internals@lists.php.net;
> andi@php.net; dmitry@php.net
> Subject: RE: [PHP-DEV] Patch for macros for tracking refcount and
> is_ref
>
> On Thu, 6 Sep 2007, Andi Gutmans wrote:
>
> > In general the patch is fine.
> > The only thing which I'd like to change is to make sure the __gc
> naming
> > is in an #if ZEND_GC for now otherwise we'll be breaking lots of
> third
> > party libraries and PECL extensions.
>
> But you might want to wonder if that's not a good thing? Without the
> prefix there will be no indication for third party extensions that they
> might be doing something that's not going to work nicely with the new
> GC
> anymore. I'd prefer it to have the __gc always there.
GC will probably not always be enabled; at least not to begin with (in fact many apps won't
even need it). Let's not run before we walk. There's still testing and review and some
stabilizing period we should be doing (as we discussed previously).
For now, we shouldn't with PHP 5.3 just break any extension (source compatibility) out there.
If GC is not being used it should compile and work just fine.
Andi