Re: faster & public domain MD5 implementation

2007/12/20, Stanislav Malyshev <stas@zend.com>: > > > Attached is a quick patch for PHP 5.2.5 that replaces RSA's copyrighted > > implementation of MD5 with my public domain one: > > > > > > http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/ > > Tried that one and it is about 30% faster indeed (on md5-only benchmark, > 32-bit Linux on AMD Opteron. Anybody objects to accepting this? > > Just one, but is a mere formality. I didn't see any copyright notice on the code nor a licensing document attached. I have not much of the legal mumbo-jumbo comprehension, so, correct me if I'm wrong, shouldn't external code that's to be included in the php codebase meet these legal formalities so it doesn't become a liability? That's all. Best Regards, Martin Alterisio PS: Does anyone knows if using a nickname for authorship is considered legally valid? I believe it might be valid, think about writers that use such pseudonyms, but I'm not sure...