Re: untie the MD4 code from MD5 & replace the MD5 code
| From: | Solar Designer | Date: | Thu, 07 Feb 2008 13:53:36 +0000 |
| Subject: | Re: untie the MD4 code from MD5 & replace the MD5 code | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-35298@lists.php.net to get a copy of this message | ||
On Thu, Feb 07, 2008 at 04:21:15PM +0300, Dmitry Stogov wrote:
> I assume now the patch is ready to commit.
> I'll commit it tomorrow in case of no objections.
Yes, it is. No objections from me.
Just two minor points:
1. You have not yet fixed the size_t vs. php_uint32 issue in
PHP_MD5Final(), leaving it inconsistent with PHP_MD5Update(). This
should not affect correctness of the code, but it's just weird.
2. The way you have re-formatted my comments still looks weird to me.
Thanks,
Alexander