Re: faster & public domain MD5 implementation
| From: | Antony Dovgal | Date: | Fri, 21 Dec 2007 09:16:08 +0000 |
| Subject: | Re: faster & public domain MD5 implementation | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-34196@lists.php.net to get a copy of this message | ||
On 21.12.2007 05:15, Martin Alterisio wrote:
>>
>> http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d/md5/
>>
>> Tried that one and it is about 30% faster indeed (on md5-only benchmark,
>> 32-bit Linux on AMD Opteron. Anybody objects to accepting this?
>>
>>
> Just one, but is a mere formality. I didn't see any copyright notice on the
> code nor a licensing document attached. I have not much of the legal
> mumbo-jumbo comprehension, so, correct me if I'm wrong, shouldn't external
> code that's to be included in the php codebase meet these legal formalities
> so it doesn't become a liability?
Good point, the license should be explicitly specified.
I'm going to test the patch on Linux/64bit today.
--
Wbr,
Antony Dovgal