Re: [patch] expose PHP version details as constants
| From: | Lars Strojny | Date: | Mon, 11 Feb 2008 16:55:40 +0000 |
| Subject: | Re: [patch] expose PHP version details as constants | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-35386@lists.php.net to get a copy of this message | ||
Hi Pierre,
Am Montag, den 11.02.2008, 17:42 +0100 schrieb Pierre Joye:
[...]
> Looks better :)
Thank you!
> I did not test it but it looks good. Did you run the tests suite?
>
> + dirname = estrndup(filename, strlen(filename));
> + zend_dirname(dirname, strlen(dirname));
>
> One strlen can be dropped here.
Ah, good hint. See http://lars.schokokeks.org/php/dir-constant-5.diff
for the corrected version.
cu, Lars
Attachment: [application/pgp-signature] Dies ist ein digital signierter Nachrichtenteil signature.asc
Attachment: [application/pgp-signature] Dies ist ein digital signierter Nachrichtenteil signature.asc