Re: [patch] expose PHP version details as constants
| From: | Stanislav Malyshev | Date: | Mon, 11 Feb 2008 21:25:30 +0000 |
| Subject: | Re: [patch] expose PHP version details as constants | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-35397@lists.php.net to get a copy of this message | ||
I'm not sure what happens if zend_dirname returns 0, also what happens if this constant is used in eval(), stream of anything else with non-canonical filename? Except that, looks ok. Some tests won't hurt though :) -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.comand it should be good. Stan, looks ok for you?Done: http://lars.schokokeks.org/php/dir-constant-6.diff