Re: [patch] expose PHP version details as constants
| From: | Pierre Joye | Date: | Mon, 11 Feb 2008 16:58:04 +0000 |
| Subject: | Re: [patch] expose PHP version details as constants | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-35387@lists.php.net to get a copy of this message | ||
On Feb 11, 2008 5:55 PM, Lars Strojny <lars@strojny.net> wrote:
> Hi Pierre,
>
> Am Montag, den 11.02.2008, 17:42 +0100 schrieb Pierre Joye:
> [...]
> > Looks better :)
>
> Thank you!
>
> > I did not test it but it looks good. Did you run the tests suite?
> >
> > + dirname = estrndup(filename, strlen(filename));
> > + zend_dirname(dirname, strlen(dirname));
> >
> > One strlen can be dropped here.
>
> Ah, good hint. See
> http://lars.schokokeks.org/php/dir-constant-5.diff
> for the corrected version.
One more thing:
const size_t filename_len = strlen(filename);
and it should be good. Stan, looks ok for you?
--
Pierre
http://blog.thepimp.net | http://www.libgd.org