Re: [patch] expose PHP version details as constants

And for the reasons why they're not needed in 5.2 apply to any other PHP version. version_compare() is there for a reason, USE IT! No more constants for same thing, thankyouverymuch. --Jani On Mon, 2008-02-11 at 11:35 -0500, Ilia Alshanetsky wrote: > We spoke about this via IM, but its only fair that the answer be > provided via a mailing list as well. > > From my standpoint this is a feature, although a minute one and 5.2 > is not in a feature mode right now, we have 5.3 and PHP 6 for that. > Secondly these constants are of dubious value (besides making code > slightly shorter) since nearly everything they offer can already be > done via the existing PHP_VERSION constant and version_compare. Big > version checks like the ones for 5 vs 6 you don't even need version > compare: > if (PHP_VERSION > 6) etc... > > Therefor, for these two reasons I do not believe we need these > constants in 5.2 branch. > > On 11-Feb-08, at 9:20 AM, Pierre Joye wrote: > > > On Feb 9, 2008 2:39 PM, Marcus Boerger <helly@php.net> wrote: > >> Hello Pierre, > >> yeah nice idea. I am wondering if you might want to add the cvs > >> tag, too? > >> E.g.: PHP_TAG = 'PHP_5_3' > > > > > > I'll commit the patch later today, I think PHP_BRANCHE sounds better > > than PHP_TAG, or PHP_CVS_TAG (but if we move away from CVS? :-D ) > > > > > > Ilia, I know you see no use of this but is it ok to apply it to 5.2 > > too? > > > > Cheers, > > -- > > Pierre > > http://blog.thepimp.net | > > http://www.libgd.org > > Ilia Alshanetsky > -- Patches/Donations: http://pecl.php.net/~jani/