Re: [PATCH] Some string changes/optimizations
| From: | Nuno Lopes | Date: | Mon, 05 May 2008 17:38:50 +0000 |
| Subject: | Re: [PATCH] Some string changes/optimizations | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-37469@lists.php.net to get a copy of this message | ||
Thanks Matt for the nice work :)
Also removed the ST_START_[HEREDOC|NOWDOC] states in the scanner, by doing their work (to catch immediate ending label) in the initial heredoc rule.This one was in my todo list as well. I think there might be other places where a similar optimization can be done.
Oh, almost forgot a couple things -- for HEAD: updated the yyless() definition to match 5_3 (Nuno didn't get to it yet...), and moved (...)
P.S. (for Marcus?), the ({LABEL}|([']{LABEL}['])|(["]{LABEL}["])) part of the heredoc rule crashed re2c (Windows) until I added the extra ( ), which shouldn't be needed AFAIK and was fine with just 2 alternate matches...Thanks. I didn't commit the yyless() merge yet because it was crashing re2c. I found it to be related with 2 different bugs in re2c. I've fixed one, but the other is still there. Maybe I should pass the details to Marcus, as I don't have time to fix it myself until the end of the month. Nuno