Re: [PATCH] Some string changes/optimizations

Hi Rasmus, Sorry about the patch format. :-/ It's been updated to correct that, as well as fix a test failure that Felipe mentioned. And as Felipe said, the invalid opcode is because the patch doesn't include the zend_vm_execute.h changes, and zend_vm_gen.php needs to be run first. I also should have mentioned that! - Matt ----- Original Message ----- From: "Rasmus Lerdorf" Sent: Monday, May 05, 2008 > A bit of a messy patch in that it doesn't have a single top-level > directory, but after hacking it, it applied. For others testing this, > make sure you run ext/tokenizer/tokenizer_data_gen.sh and of course > genfiles with the latest re2c. > > I'm still not getting something that works though. Everything compiles > fine, but make test is throwing: > > Fatal error: Invalid opcode 56/16/8. in > /Users/rasmus/php53/run-tests.php on line 547 > > Could we get a cleaner patch to have a look at? One that doesn't hurt > my brain quite as much to get working? > > -Rasmus