Re: [PATCH] Some string changes/optimizations
| From: | Felipe Pena | Date: | Tue, 06 May 2008 00:46:30 +0000 |
| Subject: | Re: [PATCH] Some string changes/optimizations | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-37491@lists.php.net to get a copy of this message | ||
> Fatal error: Invalid opcode 56/16/8. in
> /Users/rasmus/php53/run-tests.php on line 547
>
> Could we get a cleaner patch to have a look at? One that doesn't hurt
> my brain quite as much to get working?
>
Because he doesn't attached the regenerated zend_vm_execute.h in the
patch.
> Matt Wilmas wrote:
> > Hi all,
> >
> > This patch... Saves one opcode per interpolated string by moving what was
> > the first ADD_STRING/ADD_VAR op into INIT_STRING; changes the
> > ADD_[CHAR|STRING|VAR] op types from (TMP, <whatever>) to (<whatever>,
> > UNUSED), since that seems to make more sense (see ADD_ARRAY_ELEMENT) and
> > simplifies things a bit, and saves some znode copying while compiling.
> >
> > http://realplain.com/php/string_optimizations.diff
> > http://realplain.com/php/string_optimizations_5_3.diff
> >
Hi Matt, the nowdoc_015.phpt fails in HEAD.
--
Regards,
Felipe Pena.