Re: [RFC] Zend Signal Handling

hi! On Sun, Aug 3, 2008 at 9:34 AM, Lucas Nealan <lnealan@facebook.com> wrote: > Reviewed to my ability and will soon be posting the updated patch for 5_3 > and 6 as well as wiki changes. > > On 8/1/08 6:45 PM, "Arnaud Le Blanc" <arnaud.lb@gmail.com> wrote: >> The ZTS-enabled version of your patch can be found at [1] :) >> Changes: >> Zend Signal Handling is now enabled in ZTS builds. > > Should we be making sure we're not on windows before fully enabling in ZTS > builds? This could also affect platforms that do not have PTHREADS > available. I assume in the latter case we'll compile but standard > sigprocmask will not be be safe enough. We also provide binaries for non ZTS mode, so if the patch is not ready for Windows, it should disable this feature on Windows. Please let us know once you are far enough to envisage a port to windows. We can then try to do it and enable it in our snapshots (once your patch is committed :). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org