Re: [RFC] Zend Signal Handling

On 8/5/08 3:45 AM, "Arnaud Le Blanc" <arnaud.lb@gmail.com> wrote: > In the case of pcntl_signal(), if it registers a handler for a signal, the > signal will be delivered to zend_signal_handler_defer(), which will call > zend_signal_handler() if not in critical section, which will call the actual > handler registered by pcntl_signal(), pcntl_signal_handler(). Then the user > signal handler will be called at the next tick or the next time > zend_signal_dispatch() is called. Ah well I would have to be running on the latest patch. I just integrated and it looks good. This did seem a bit weird though: +++ Zend/zend_hash.c (.../HEAD_signals) (revision 34) @@ -509,6 +509,9 @@ { uint nIndex; Bucket *p; + TSRMLS_FETCH(); + TSRMLS_FETCH(); + TSRMLS_FETCH(); I took all but one of these out and also have fixed a couple trailing whitespace/tab issues in my git repo. Just to keep everything consistent I'll update the patches tomorrow. Considering our status now it does seem like a good point to ask for a commit, at least to HEAD. I assume now is also the time for things to be committed to 5.3 for alpha 2. -lucas