Re: [RFC] Zend Signal Handling

Arnaud Le Blanc wrote:

Hi, As Lucas said the patch seems ready now, could someone please review the patch for inclusion ? http://wiki.php.net/rfc/zendsignals Changes that have been made: - The patch has been ported to HEAD - The patch now supports multithreaded environments, and fixes many problems on non-windows platforms when enabled. - Extensions can use zend_signal() and zend_sigaction() so that all signals they declare will always be deferred in critical sections. PCNTL has been ported. - There is now a zend.signal_check ini entry so that the checks made in zend_signal_deactivate() can be done in non-debug builds. - Some code has been moved to process startup or global constructor routines. - The patch moves some HANDLE_BLOCK/UNBLOCK in zend_alloc to protect more code

And don't forget that there was no protection before at all in any SAPI other than Apache1 because HANDLE_BLOCK_INTERRUPTIONS() is a NOP on every other SAPI. We effectively had no critial sections at all prior to this patch. -Rasmus