Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l
| From: | Hannes Magnusson | Date: | Fri, 17 Apr 2009 09:07:29 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-43724@lists.php.net to get a copy of this message | ||
On Fri, Jan 2, 2009 at 00:40, Johannes Schlüter <johannes@php.net> wrote:
> On Thu, 2009-01-01 at 15:46 -0500, Ilia Alshanetsky wrote:
>> Nuno,
>>
>> The original code actually can be found inside php_cli.c and there it
>> only checked the 1st line for '#'. if you create a file such as:
>> #1
>> #2
>> <?php $a = array();
>
> The issue here is that the old code only looked at the main script, now
> included files ar affected, too.
>
> So either we check in the scanner whether this is the main script or
> move the check back to the C[GL]I SAPIs.
What is the status on this?
Are we hoping run-tests.php is the only script affected, or is someone
working on another fix?
-Hannes