Re: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l

I'm pretty sure yes. Try copying the run-tests.php from 5_2 to 5_3 and run the PDO tests with it. Then diff the run-tests to see the workaround in 5.3. -Hannes On Sun, Apr 19, 2009 at 17:57, Ilia Alshanetsky <ilia@prohost.org> wrote: > Last I checked it was working properly, are you sure you are using the > latest version? I think we even have a test case around this bug. > > > Ilia Alshanetsky > > > > > On 19-Apr-09, at 7:09 AM, Hannes Magnusson wrote: > >> On Sat, Apr 18, 2009 at 23:48, Nuno Lopes <nlopess@php.net> wrote: >>>>>> >>>>>> The original code actually can be found inside php_cli.c and there it >>>>>> only checked the 1st line for '#'. if you create a file such as: >>>>>> #1 >>>>>> #2 >>>>>> <?php $a = array(); >>>>> >>>>> The issue here is that the old code only looked at the main script, now >>>>> included files ar affected, too. >>>>> >>>>> So either we check in the scanner whether this is the main script or >>>>> move the check back to the C[GL]I SAPIs. >>>> >>>> What is the status on this? >>>> Are we hoping run-tests.php is the only script affected, or is someone >>>> working on another fix? >>> >>> AFAIR, this was already fixed by Ilia some time ago. >> >> Nope. The run-tests.php workaround is still required (manually adding >> the "# original source file.." comments). >> >> -Hannes > >