Re: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l
| From: | Hannes Magnusson | Date: | Sun, 19 Apr 2009 11:09:04 +0000 |
| Subject: | Re: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-43733@lists.php.net to get a copy of this message | ||
On Sat, Apr 18, 2009 at 23:48, Nuno Lopes <nlopess@php.net> wrote:
>>>> The original code actually can be found inside php_cli.c and there it
>>>> only checked the 1st line for '#'. if you create a file such as:
>>>> #1
>>>> #2
>>>> <?php $a = array();
>>>
>>> The issue here is that the old code only looked at the main script, now
>>> included files ar affected, too.
>>>
>>> So either we check in the scanner whether this is the main script or
>>> move the check back to the C[GL]I SAPIs.
>>
>> What is the status on this?
>> Are we hoping run-tests.php is the only script affected, or is someone
>> working on another fix?
>
> AFAIR, this was already fixed by Ilia some time ago.
Nope. The run-tests.php workaround is still required (manually adding
the "# original source file.." comments).
-Hannes