Re: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l

From:	Ilia Alshanetsky	Date:	Sun, 19 Apr 2009 15:57:19 +0000
Subject:	Re: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_language_scanner.c zend_language_scanner.l
References:	1 2 3 4 5 6 7	Groups:	php.internals
Request:	Send a blank email to internals+get-43734@lists.php.net to get a copy of this message

Last I checked it was working properly, are you sure you are using the latest version? I think we even have a test case around this bug. Ilia Alshanetsky On 19-Apr-09, at 7:09 AM, Hannes Magnusson wrote:

On Sat, Apr 18, 2009 at 23:48, Nuno Lopes <nlopess@php.net> wrote:
The original code actually can be found inside php_cli.c and there it only checked the 1st line for '#'. if you create a file such as: #1 #2 <?php $a = array();
The issue here is that the old code only looked at the main script, now included files ar affected, too. So either we check in the scanner whether this is the main script or move the check back to the C[GL]I SAPIs.
What is the status on this? Are we hoping run-tests.php is the only script affected, or is someone working on another fix?
AFAIR, this was already fixed by Ilia some time ago.
Nope. The run-tests.php workaround is still required (manually adding the "# original source file.." comments). -Hannes