Re: [PATCH] FNV-1 support for ext/hash

From:	Michael Maclean	Date:	Tue, 23 Mar 2010 23:18:09 +0000
Subject:	Re: [PATCH] FNV-1 support for ext/hash
References:	1 2	Groups:	php.internals
Request:	Send a blank email to internals+get-47535@lists.php.net to get a copy of this message

sean finney wrote:

On Tue, Mar 23, 2010 at 10:01:20PM +0000, Michael Maclean wrote:
The patch: http://mgdm.net/~michael/patches/php-fnv.txt
just to throw something out there, shouldn't the various inputLen parameters be of type size_t instead of unsigned int?

The function signature in php_hash.g says unsigned int, so that's what I used (though I note some of the other algorithms appear not to). We don't support files > 2^32 on 64-bit, so as I understand it, it's not going to cause issues right now, but if a large file support patch lands it's something that I might revisit. -- Cheers, Michael