Re: [PATCH] FNV-1 support for ext/hash
| From: | Michael Maclean | Date: | Tue, 23 Mar 2010 23:31:05 +0000 |
| Subject: | Re: [PATCH] FNV-1 support for ext/hash | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47536@lists.php.net to get a copy of this message | ||
Michael Maclean wrote:
The function signature in php_hash.g says unsigned int, so that's what I used (though I note some of the other algorithms appear not to). We don't support files > 2^32 on 64-bit, so as I understand it, it's not going to cause issues right now, but if a large file support patch lands it's something that I might revisit. And of course, when I say "file" here, I mean "string". Ahem.-- Cheers, Michael